Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stream)!: Prevent slicing on non-UTF8 boundaries #471

Merged
merged 4 commits into from
Feb 12, 2024
Merged

fix(stream)!: Prevent slicing on non-UTF8 boundaries #471

merged 4 commits into from
Feb 12, 2024

Conversation

epage
Copy link
Collaborator

@epage epage commented Feb 12, 2024

Fixes #460

@codecov Codecov
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@d049ebd). Click here to learn what that means.

Files Patch % Lines
src/stream/mod.rs 25.92% 20 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage        ?   41.86%           
=======================================
  Files           ?       18           
  Lines           ?     3096           
  Branches        ?        0           
=======================================
  Hits            ?     1296           
  Misses          ?     1800           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7877832235

Details

  • -20 of 28 (28.57%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.08%) to 41.86%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stream/mod.rs 7 27 25.93%
Files with Coverage Reduction New Missed Lines %
src/ascii/mod.rs 2 54.23%
src/stream/mod.rs 2 25.71%
Totals Coverage Status
Change from base Build 7877523483: 0.08%
Covered Lines: 1296
Relevant Lines: 3096
💛 - Coveralls

@epage epage merged commit 46c77dc into winnow-rs:main Feb 12, 2024
17 checks passed
@epage epage deleted the byte branch February 12, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Byte comparisons for &str streams can panic or worse
2 participants
@epage @coveralls